Skip to content

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Aug 22, 2025

No description provided.

@ludfjig ludfjig changed the title Clear mutex poision if previous host function panicked [test] Clear mutex poision if previous host function panicked Aug 22, 2025
@ludfjig ludfjig added the kind/bugfix For PRs that fix bugs label Aug 22, 2025
jprendes
jprendes previously approved these changes Aug 27, 2025
Copy link
Contributor

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ludfjig ludfjig force-pushed the poison_mutex_fix branch 3 times, most recently from 09c2499 to bfe7986 Compare August 27, 2025 22:54
@ludfjig ludfjig closed this Aug 28, 2025
@syntactically
Copy link
Member

I would like to be careful to avoid adding too much reliance on single-threadedness, since that might change in the future, or at least being extremely clear about where it is and how it would need to change.

I also think that a host function failure should probably poison the sandbox, requiring it to be restored before it can be used again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bugfix For PRs that fix bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants